Skip to content

Rubocop: extract ErrorExplanation component #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rails-template-sync wants to merge 1 commit into from
+97 −0
Closed

Rubocop: extract ErrorExplanation component #1514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions app/components/error_explanation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# frozen_string_literal: true

module Components
class ErrorExplanation < Components::Base
attr_accessor :errors

def initialize(errors:)
super()
self.errors = errors
end

def view_template
return if errors.none?

div(class: "error-explanation") do
h2 { "Something went wrong" }
ul do
errors.full_messages.each { |message| li { message } }
end
end
end
end
end
41 changes: 41 additions & 0 deletions app/views/accounts/new.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# frozen_string_literal: true

module Views
module Accounts
class New < Views::Base
attr_accessor :user

def initialize(user:)
super()
self.user = user
end

def view_template
h1 { "New Account" }

form_with(model: user, url: account_path) do |form|
render(Components::ErrorExplanation.new(errors: user.errors))

div(class: "field") do
form.label(:email)
form.email_field(:email, required: true)
end

div(class: "field") do
form.label(:password)
form.password_field(:password, required: true)
end

div(class: "field") do
form.label(:password_confirmation)
form.password_field(:password_confirmation, required: true)
end

div(class: "actions") do
form.submit("Create Account")
end
end
end
end
end
end
33 changes: 33 additions & 0 deletions app/views/accounts/show.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# frozen_string_literal: true

module Views
module Accounts
class Show < Views::Base
attr_accessor :user

def initialize(user:)
super()
self.user = user
end

def view_template
h1 { "My Account" }

form_with(model: user, url: account_path) do |form|
render(Components::ErrorExplanation.new(errors: user.errors))

div(class: "field") do
form.label(:email)
form.email_field(:email, required: true)
end

div(class: "actions") do
form.submit("Update Account")
end
end

button_to("Delete Account", account_path, method: :delete)
end
end
end
end
Loading