Skip to content

Swift 3 support#4

Merged
stringcode86 merged 4 commits into
stringcode86:masterfrom
kreeger:swift3
Oct 3, 2016
Merged

Swift 3 support#4
stringcode86 merged 4 commits into
stringcode86:masterfrom
kreeger:swift3

Conversation

@kreeger
Copy link
Copy Markdown
Contributor

@kreeger kreeger commented Sep 27, 2016

Hey! Thanks for this framework — the feature is great fun for our users during holiday season. :) That said, we can't get through holiday season without getting through Swift 3 Migration Season, so I've updated this project for Swift 3 compatibility.

I've also moved the podspec to the repo's root — it seemed to be the only way to get this library to work when pointing a project to it using a GitHub repository URL in a Podfile.

Thanks — and lemme know if you have any questions.

@stringcode86
Copy link
Copy Markdown
Owner

Hi Ben,

Sorry for late reply and thank you for doing all the work ! Excellent job, I am going to merge it into master some time over this weekend.
Thank you very much again, have a nice rest of the weekend !

Michael
@stringcode https://twitter.com/stringcode
stringcode.co.uk http://www.stringcode.co.uk/

On 27 Sep 2016, at 18:20, Ben Kreeger [email protected] wrote:

Hey! Thanks for this framework — the feature is great fun for our users during holiday season. :) That said, we can't get through holiday season without getting through Swift 3 Migration Season, so I've updated this project for Swift 3 compatibility.

I've also moved the podspec to the repo's root — it seemed to be the only way to get this library to work when pointing a project to it using a GitHub repository URL in a Podfile.

Thanks — and lemme know if you have any questions.

You can view, comment on, or merge this pull request online at:

#4 #4
Commit Summary

Make updates for Swift 3.
Update files in CocoaPods.
Update sample project files.
Move podspec to root of repo.
File Changes

M Podyfied/SnowGlobe/Pod/Classes/Numbers+Extentios.swift https://github.com/stringcode86/SnowGlobeFramework/pull/4/files#diff-0 (6)
M Podyfied/SnowGlobe/Pod/Classes/SnowGlobeView.swift https://github.com/stringcode86/SnowGlobeFramework/pull/4/files#diff-1 (104)
R SnowGlobe.podspec https://github.com/stringcode86/SnowGlobeFramework/pull/4/files#diff-2 (0)
M SnowGlobe/SnowGlobe.xcodeproj/project.pbxproj https://github.com/stringcode86/SnowGlobeFramework/pull/4/files#diff-3 (17)
M SnowGlobe/SnowGlobe/Numbers+Extentios.swift https://github.com/stringcode86/SnowGlobeFramework/pull/4/files#diff-4 (6)
M SnowGlobe/SnowGlobe/SnowGlobeView.swift https://github.com/stringcode86/SnowGlobeFramework/pull/4/files#diff-5 (92)
M SwiftSample/SwiftSample.xcodeproj/project.pbxproj https://github.com/stringcode86/SnowGlobeFramework/pull/4/files#diff-6 (19)
M SwiftSample/SwiftSample/AppDelegate.swift https://github.com/stringcode86/SnowGlobeFramework/pull/4/files#diff-7 (4)
M SwiftSample/SwiftSample/ThreeViewController.swift https://github.com/stringcode86/SnowGlobeFramework/pull/4/files#diff-8 (2)
M SwiftSample/SwiftSample/TwoViewController.swift https://github.com/stringcode86/SnowGlobeFramework/pull/4/files#diff-9 (2)
M SwiftSample/SwiftSampleTests/SwiftSampleTests.swift https://github.com/stringcode86/SnowGlobeFramework/pull/4/files#diff-10 (2)
Patch Links:

https://github.com/stringcode86/SnowGlobeFramework/pull/4.patch https://github.com/stringcode86/SnowGlobeFramework/pull/4.patch
https://github.com/stringcode86/SnowGlobeFramework/pull/4.diff https://github.com/stringcode86/SnowGlobeFramework/pull/4.diff

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub #4, or mute the thread https://github.com/notifications/unsubscribe-auth/AEVNe6Vc525NaaN-PP0z1uLU0diIJTv_ks5quVBSgaJpZM4KH7kj.

@stringcode86 stringcode86 merged commit 2e4f511 into stringcode86:master Oct 3, 2016
@kreeger kreeger deleted the swift3 branch October 4, 2016 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants