Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: stormpath/express-stormpath-angular-sample-project
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: stormpath/express-stormpath-angular-sample-project
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.x
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 5 files changed
  • 1 contributor

Commits on Jan 18, 2017

  1. Upgrade angular SDK to 2.0

    Robert committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    02b7e8e View commit details
    Browse the repository at this point in the history

  2. Demonstrate dependency issue with upgraded UI-Router 

    You should see the error:

```
angular.js:4442 Uncaught Error: Unrecognised token store: localStorage
    at Object.getTokenStore (stormpath-sdk-angularjs.js:3394)
    at new StormpathOAuthToken (stormpath-sdk-angularjs.js:2322)
    at StormpathOAuthTokenProvider.$get (stormpath-sdk-angularjs.js:2476)
    at Object.invoke (angular.js:4478)
    at angular.js:4295
    at getService (angular.js:4437)
    at Object.invoke (angular.js:4469)
    at Object.enforcedReturnValue [as $get] (angular.js:4330)
    at Object.invoke (angular.js:4478)
    at angular.js:4295
```

Moving the UI Router below stormpath will fix the prolem:

```
angular.module('exampleApp', [
  'stormpath',
  'stormpath.templates’,
  'ui.router'
])
```
    Robert committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    66f5ed2 View commit details
    Browse the repository at this point in the history
Loading