Skip to content

Commit 13b1d85

Browse files
committed
refactor(forms): removed iterableToList
1 parent c6409cb commit 13b1d85

4 files changed

Lines changed: 3 additions & 13 deletions

File tree

‎modules/angular2/src/facade/collection.dart‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,6 @@ class ListWrapper {
195195

196196
bool isListLikeIterable(obj) => obj is Iterable;
197197

198-
List iterableToList(Iterable ii) => ii.toList();
199-
200198
void iterateListLike(iter, fn(item)) {
201199
assert(iter is Iterable);
202200
for (var item in iter) {

‎modules/angular2/src/facade/collection.ts‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -260,13 +260,6 @@ export function iterateListLike(obj, fn: Function) {
260260
}
261261
}
262262
}
263-
export function iterableToList<T>(ii: any): List<T> {
264-
var res = [];
265-
for (var i of ii) {
266-
res.push(i);
267-
}
268-
return res;
269-
}
270263

271264
// Safari and Internet Explorer do not support the iterable parameter to the
272265
// Set constructor. We work around that by manually adding the items.

‎modules/angular2/src/forms/directives/shared.ts‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {ListWrapper, iterableToList, StringMapWrapper} from 'angular2/src/facade/collection';
1+
import {ListWrapper, StringMapWrapper} from 'angular2/src/facade/collection';
22
import {isBlank, BaseException, looseIdentical} from 'angular2/src/facade/lang';
33

44
import {ControlContainer} from './control_container';
@@ -39,8 +39,7 @@ export function setUpControl(c: Control, dir: NgControl) {
3939

4040
export function composeNgValidator(ngValidators: QueryList<NgValidator>): Function {
4141
if (isBlank(ngValidators)) return Validators.nullValidator;
42-
return Validators.compose(
43-
(<List<NgValidator>>iterableToList(ngValidators)).map(v => v.validator));
42+
return Validators.compose(ngValidators.map(v => v.validator));
4443
}
4544

4645
function _throwError(dir: NgControl, message: string): void {

‎modules/angular2/test/core/compiler/query_integration_spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import {QueryList} from 'angular2/core';
1919
import {Query, ViewQuery, Component, Directive, View} from 'angular2/annotations';
2020

2121
import {NgIf, NgFor} from 'angular2/angular2';
22-
import {ListWrapper, iterableToList} from 'angular2/src/facade/collection';
22+
import {ListWrapper} from 'angular2/src/facade/collection';
2323

2424
import {BrowserDomAdapter} from 'angular2/src/dom/browser_adapter';
2525

0 commit comments

Comments
 (0)