Repository navigation
#154 Add option to set the subscription id for durable subscriptions. - #151
Merged
Merged
Conversation
To create a durable subscription the client-id header must be set on the CONNECT frame and the durable-subscription-name must be set on the SUBSCRIBE frame. The combination of these two headers will form the identity of the durable subscription. Source https://activemq.apache.org/components/artemis/documentation/2.7.0/stomp.html#durable-subscriptions So instead of sending the client-id in the SUBSCRIBE frame, we should send the subscription id.
MPParsley
commented
Dec 16, 2020
MPParsley
commented
Dec 16, 2020
MPParsley
commented
Dec 17, 2020
Run phpunit with XDEBUG_MODE=coverage Some constants are only available in certain modes in Xdebug 3. This is fixed in the latest Xdebug release but not yet available in the version used by Travis. Also, it won't hurt to run xdebug in coverage mode. See: xdebug/xdebug#699
Fix Xdebug error in Travis
MPParsley
commented
Dec 17, 2020
MPParsley
commented
Dec 17, 2020
MPParsley
commented
Dec 17, 2020
MPParsley
commented
Dec 17, 2020
MPParsley
commented
Dec 17, 2020
MPParsley
commented
Dec 17, 2020
MPParsley
commented
Dec 17, 2020
MPParsley
commented
Dec 17, 2020
durable-subscription-name is deprecated
MPParsley
commented
Dec 18, 2020
Member
|
@MPParsley Thank you for the PR, I'm sorry for that huge delay. |
Contributor
Author
|
No problem, thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source https://activemq.apache.org/components/artemis/documentation/2.7.0/stomp.html#durable-subscriptions
Note: for AMQ 5.6 the client-id should be identical to the subscriptionName. This is no longer valid for Artemis.
https://stackoverflow.com/questions/13137557/activemq-durable-consumer-is-in-use-for-client-and-subscriptionname-via-stomp/13146955#13146955
So instead of sending the activemq.subscriptionName header with the client-id in the SUBSCRIBE frame, we should send the durable-subscription-name header for Artemis.
The code in the PR adds support for backwards compatibility.