improve the confused assert message - #96
Merged
Merged
Conversation
stleary
reviewed
Dec 29, 2019
stleary
reviewed
Dec 29, 2019
stleary
reviewed
Dec 29, 2019
stleary
reviewed
Dec 29, 2019
stleary
reviewed
Dec 29, 2019
stleary
reviewed
Dec 29, 2019
stleary
reviewed
Dec 29, 2019
stleary
reviewed
Dec 29, 2019
stleary
reviewed
Dec 29, 2019
stleary
reviewed
Dec 29, 2019
stleary
reviewed
Dec 29, 2019
stleary
reviewed
Dec 29, 2019
stleary
reviewed
Dec 29, 2019
stleary
reviewed
Dec 29, 2019
stleary
reviewed
Dec 29, 2019
Owner
|
@Alanscut thanks for helping improve the unit tests. I think some of your assert messages may still be off, have commented same. Let me know if you disagree. |
Co-Authored-By: Sean Leary <[email protected]>
Contributor
Author
|
@stleary Thanks your suggestion! It make the assert messages more clear 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test cases for bean parse are good, but some assert messages make people coufused, some fields are found but described as not working, while another fields are not found but described as found.