Warn against unsupported Python version when running CLI#575
Merged
Conversation
dkolas
approved these changes
Oct 6, 2023
Contributor
dkolas
left a comment
dkolas
left a comment
There was a problem hiding this comment.
I really like where / how you've injected this. It feels like it's at a place where you have the developer's attention but warning them about something won't feel overly annoying or hostile.
Only q: Do we want to specifically call out the issues around 3.11 in the warning message? To potentially make it less likely to be hand waved away in that case?
Contributor
Author
I think that could be misleading, since we know of issues with enums, but there could be more issues that we haven't found yet. |
…eorge/version-assertion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the initialization of the CLI, check the Python version and warn if it's not supported.
I took this approach to attempt to be nice, rather than immediately explode in the SDK itself, though the SDK could certainly leverage the
__init__.pycode here.When running on 3.8:
When running on 3.11:
When running on 3.10: