[SHIP-834] [SHIP-818] Streaming Generators#548
Merged
Conversation
dkolas
changed the title
eob
approved these changes
Sep 11, 2023
Contributor
eob
left a comment
eob
left a comment
There was a problem hiding this comment.
LGTM! This is really exciting
| class StreamState(str, Enum): | ||
| STARTED = "started" # A producer has begun streaming to this block. | ||
| COMPLETE = "complete" # The producer has finished streaming to this block successfully. | ||
| ABORTED = "aborted" # The producer finished streaming to the block, but there was an error. |
Contributor
There was a problem hiding this comment.
nit: I don't think this is a huge deal, but if you wanted to align with the enums we use in the task system I think these would be: running, succeeded, failed
| return f"{self.id}" | ||
| return f"Block({self.id})" | ||
|
|
||
| def finish_stream(self): |
Contributor
There was a problem hiding this comment.
Oh I see you were aiming for alignment with these routes
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes:
Blockfor streamingDepends on: https://github.com/nludb/nludb/pull/631
(tests will fail until deploy of above)