Tag ChatHistory blocks and files #531
Merged
Merged
Conversation
dkolas
previously approved these changes
Aug 30, 2023
Contributor
dkolas
left a comment
dkolas
left a comment
There was a problem hiding this comment.
Looks good - one suggestion for a new tag kind
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't currently Tag ChatHistory files as being ChatHistory files. That means that the Web UI can't show a list of prior chats and let the user resume or browse one.
This PR adds a tag constant for ChatHistory and tags new ChatHistory files with it when they are created.
Along for the ride on this PR
experimentalget_tag_value_keymethods into a singletag_util.pyfile.build_chat_history_for_toolfunction fromnext_actionto enable testing on its own and possible resuse