feat: add C implementation for math/base/special/betaincinv - #15384
Open
Planeshifter wants to merge 2 commits into
Open
Planeshifter wants to merge 2 commits into
Planeshifter wants to merge 2 commits into
Conversation
Planeshifter
added this pull request to stack #15385
September 21, 2026 04:49
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Planeshifter
marked this pull request as ready for review
September 21, 2026 04:58
Planeshifter
changed the title
math/base/special/betaincinv
anandkaranubc
force-pushed
the
philipp/betaincinv-c
branch
from
September 23, 2026 01:25
7d2cd55 to
a79051e
Compare
This commit adds a C/native implementation for the inverse of the regularized incomplete beta function. The C implementation delegates to the kernel-betaincinv C implementation for numerical inversion. The following files are added or modified: - Public header (betaincinv.h) - C implementation (src/main.c) delegating to kernel_betaincinv - Native add-on (src/addon.c) - Build configuration (binding.gyp, include.gypi, manifest.json) - Native JavaScript wrapper (lib/native.js) - Native JavaScript benchmark (benchmark/benchmark.native.js) - C benchmark (benchmark/c/native/) - C example (examples/c/) - Native tests (test/test.native.js) - README C API documentation - Updated package.json with gypfile and native directories Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: passed - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
- Add missing `@stdlib/constants/float64/eps` to benchmark task dependencies in manifest.json (the C benchmark uses it) - Rename benchmark callback parameter from `b` to `assert` to avoid shadowing the shape-parameter variable `b`, matching the convention used in sibling packages Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
anandkaranubc
force-pushed
the
philipp/betaincinv-c
branch
from
September 26, 2026 23:16
a79051e to
ed272fb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves stdlib-js/metr-issue-tracker#1234.
Description
This pull request:
@stdlib/math/base/special/betaincinvThe C implementation delegates to
kernel-betaincinvfor numerical inversion, mirroring the JavaScript implementation. The public function handles parameter validation (NaN, domain checks, complement handling) and returns the primary inverse value.Related Issues
This pull request has the following related issues:
math/base/special/kernel-betaincinv#13418 (philipp/kernel-betaincinv-c) which adds the required kernel C implementation.Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code under my direction.
@stdlib-js/reviewers