Taintgraph - #2
Merged
Merged
Conversation
sipma
approved these changes
Nov 1, 2020
sipma
left a comment
sipma
left a comment
Contributor
There was a problem hiding this comment.
Andrew, thank you very much for these contributions! The taint graph looks very nice; I especially like the facility to specialize the graph to particular sinks.
One suggestion would be to include some error handling for the case where a taint trail is not present; as it is, it just shows the json error file and the list of origins for which trails are available is printed on the console. Would it be possible to report back for which origins trails are available, or perhaps indicate directly in the taint origins list for which origins trails are present?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a taintgraph display accessible from the Taints tab of the main page and facilities to call taint analysis from the web interface on request. Also makes a number of visual changes to the look of graphs.