Repository navigation
Let shared selects name themselves and open like buttons, and point the Console at u4 - #242
Merged
Merged
Conversation
…he Console at u4 - Select: `inlineLabel` draws a muted name inside the control. An option's `valueLabel` gives the closed control a shorter form (the region's flag and code). A non-searchable select wears the secondary button's surface. The control height follows `--stp-control-height`. Content starts 14px in, like a text field. Menus are as wide as their longest option (up to 420px) but stop at the window edge. - Text field, select and radio group: `--stp-field-inset` moves labels, help text and errors to where the field's content starts. It defaults to 0, so other consumers are unchanged. - Dialog: opens with its first field focused instead of the close button, and its body has a thin scrollbar. - Console pointer: shared controls round 2 (console-app#94). Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the shared-package half of the Console's shared controls round 2 (stacktape/console-app#94), plus the submodule pointer. Merge the Console PR first, then point this PR at its merge commit.
packages/ui-reactchanges:inlineLabeldraws a muted name inside the control ("Region eu-west-1") for toolbars where a label above does not fit. An option'svalueLabelgives the closed control a shorter form than the menu (the region's flag and code, without the name). A non-searchable select wears the secondary button's surface and shadows. Its default height now follows--stp-control-height. Values start 14px in, where a text field's do. The menu is as wide as its longest option (up to 420px) but never past the window's right edge.--stp-field-insetmoves text field, select and radio group labels, help text and errors to where the field content starts. It defaults to 0, so the docs site and the init wizard look as before. The Console sets it to 14px.Effects on other consumers: the init wizard's region picker gets the 14px value inset and the wider menu. Nothing else in
apps/init-uiorapps/docsuses Select or Dialog.Checks:
pnpm check:integratedpassed on this tree, with ui-react unit tests 141/141, the Console's offline browser lane 48/48, and the isolated browser lane 14/14 files.