ROX-33664: Replace archived jackc/pgtype with pgx/v5/pgtype#20057
Merged
janisz merged 1 commit intorelease-4.8from Apr 17, 2026
Merged
ROX-33664: Replace archived jackc/pgtype with pgx/v5/pgtype#20057janisz merged 1 commit intorelease-4.8from
janisz merged 1 commit intorelease-4.8from
Conversation
Backport of PR #15855 to release-4.8. Replace the direct import of the archived github.com/jackc/pgtype (v4-era) with github.com/jackc/pgx/v5/pgtype in query_metadata.go. This removes our direct dependency on the archived pgtype package, which transitively pulls in pgproto3/v2 (CVE-2026-32286). The pgtype dependency remains as indirect via ClairCore, but our code no longer imports it directly. API change: pgtype.Numeric.Status != pgtype.Present → !asNumeric.Valid Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
github-actions
bot
added
area/postgres
backport
Contributor
|
Images are ready for the commit at 0aca82b. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-4.8 #20057 +/- ##
============================================
Coverage 48.73% 48.73%
============================================
Files 2595 2595
Lines 190828 190828
============================================
Hits 93005 93005
Misses 90511 90511
Partials 7312 7312
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
clickboo
approved these changes
Apr 16, 2026
davdhacs
approved these changes
Apr 16, 2026
Contributor
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NOTE: This is only a partial fix as the removal of pgproto3/v2 requires an upgrade of ClairCore
Backport of PR #15855 to release-4.8. Replace the direct import of the archived github.com/jackc/pgtype (v4-era) with github.com/jackc/pgx/v5/pgtype in query_metadata.go. This removes our direct dependency on the archived pgtype package, which transitively pulls in pgproto3/v2.
The pgtype dependency remains as indirect via ClairCore, but our code no longer imports it directly.
API change: pgtype.Numeric.Status != pgtype.Present → !asNumeric.Valid
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!