Skip to content

ROX-34153: Don't return compliance profiles if filter matches nothing #20048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guzalv wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ROX-34153: Don't return compliance profiles if filter matches nothing #20048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83be7a3
ROX-34153: return empty list in ListProfileSummaries when filter matc…
guzalv Apr 16, 2026
63b7ca9
ROX-34153: fix test to use actual profile name filter in no-match case
guzalv Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions central/complianceoperator/v2/profiles/service/service_impl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,9 @@ func (s *serviceImpl) ListProfileSummaries(ctx context.Context, request *v2.Clus
if err != nil {
return nil, errors.Wrapf(errox.InvalidArgs, "Unable to retrieve compliance profiles for %v", request)
}
if len(profileNames) == 0 {
return &v2.ListComplianceProfileSummaryResponse{}, nil
}

// Build query to get the filtered list by profile names
profileQuery := search.NewQueryBuilder().AddSelectFields().AddExactMatches(search.ComplianceOperatorProfileName, profileNames...).ProtoQuery()
Expand Down
20 changes: 20 additions & 0 deletions central/complianceoperator/v2/profiles/service/service_impl_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,26 @@ func (s *ComplianceProfilesServiceTestSuite) TestListProfileSummaries() {
setMocks: func() {
},
},
{
desc: "No profiles match filter",
query: &apiV2.ClustersProfileSummaryRequest{
ClusterIds: []string{fixtureconsts.Cluster1},
Query: &apiV2.RawQuery{Query: "Compliance Profile Name:nonexistent"},
},
expectedErr: nil,
expectedResp: []*apiV2.ComplianceProfileSummary{},
found: true,
setMocks: func() {
profileQuery, _ := search.ParseQuery("Compliance Profile Name:nonexistent", search.MatchAllIfEmpty())
paginated.FillPaginationV2(profileQuery, nil, maxPaginationLimit)
profileQuery.Pagination.SortOptions = []*apiV1.QuerySortOption{
{
Field: search.ComplianceOperatorProfileName.String(),
},
}
s.profileDatastore.EXPECT().GetProfilesNames(gomock.Any(), profileQuery, []string{fixtureconsts.Cluster1}).Return(nil, nil).Times(1)
},
},
{
desc: "Query with cluster 1",
query: &apiV2.ClustersProfileSummaryRequest{ClusterIds: []string{fixtureconsts.Cluster1}},
Expand Down
Loading