Skip to content

perf: share single lumberjack writer across loggers #20018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
davdhacs wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

perf: share single lumberjack writer across loggers #20018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions pkg/logging/logging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,14 +380,30 @@ func CreateLogger(module *Module, skip int, opts ...OptionsFunc) *LoggerImpl {
return result
}

// sharedFileWriters caches lumberjack writers by path so multiple loggers
// share one writer instead of each creating their own. This prevents:
// - 30+ goroutines for log rotation (one per lumberjack.Logger)
// - 30+ independent file handles to the same file
// - Potential log corruption from concurrent uncoordinated writes
var sharedFileWriters = make(map[string]zapcore.WriteSyncer)

func getOrCreateFileWriter(path string) zapcore.WriteSyncer {
if w, ok := sharedFileWriters[path]; ok {
return w
}
w := zapcore.AddSync(&lumberjack.Logger{
Filename: path,
MaxSize: env.LoggingMaxSizeMB.IntegerSetting(),
MaxBackups: env.LoggingMaxRotationFiles.IntegerSetting(),
})
sharedFileWriters[path] = w
return w
}

func withRotatingCores(lc *zap.Config, rotatingPaths []string) func(c zapcore.Core) zapcore.Core {
var cores = make([]zapcore.Core, 0, len(rotatingPaths))
for _, path := range rotatingPaths {
writer := zapcore.AddSync(&lumberjack.Logger{
Filename: path,
MaxSize: env.LoggingMaxSizeMB.IntegerSetting(),
MaxBackups: env.LoggingMaxRotationFiles.IntegerSetting(),
})
writer := getOrCreateFileWriter(path)
cores = append(cores, zapcore.NewCore(getEncoderForConfig(lc), writer, lc.Level))
}
return func(c zapcore.Core) zapcore.Core {
Expand Down
Loading