Skip to content

ROX-33656: Benchmark for enhanced filters#19908

Open
ksurabhi91 wants to merge 5 commits intoquery_enhanced_filtersfrom
sch_changes
Open

ROX-33656: Benchmark for enhanced filters#19908
ksurabhi91 wants to merge 5 commits intoquery_enhanced_filtersfrom
sch_changes

Conversation

@ksurabhi91
Copy link
Copy Markdown
Contributor

@ksurabhi91 ksurabhi91 commented Apr 9, 2026

This PR adds benchmark tests for enhanced filter reporting . Test creates 2000 deployed images and 500 watched images and queries data using enhanced filters, entity scope filters and access scope filter. For each test case query is run multiple times using Gos benchmark framework.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@ksurabhi91
Copy link
Copy Markdown
Contributor Author

ksurabhi91 commented Apr 9, 2026

This change is part of the following stack:

Change managed by git-spice.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 9, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

🚀 Build Images Ready

Images are ready for commit a1ad5ee. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.11.x-612-ga1ad5ee252

@ksurabhi91 ksurabhi91 force-pushed the query_enhanced_filters branch 3 times, most recently from d05c96a to e89acd6 Compare April 9, 2026 02:54
@ksurabhi91 ksurabhi91 force-pushed the query_enhanced_filters branch from e89acd6 to b463795 Compare April 9, 2026 14:31
@ksurabhi91 ksurabhi91 changed the title Scheduler changes for enhanced filters ROX-33656: Benchmark for enhanced filters Apr 14, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 75.78125% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.63%. Comparing base (9d35506) to head (a1ad5ee).
⚠️ Report is 56 commits behind head on query_enhanced_filters.

Files with missing lines Patch % Lines
central/reports/common/query_builder.go 69.00% 31 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           query_enhanced_filters   #19908      +/-   ##
==========================================================
+ Coverage                   49.61%   49.63%   +0.02%     
==========================================================
  Files                        2765     2765              
  Lines                      208541   208763     +222     
==========================================================
+ Hits                       103464   103625     +161     
- Misses                      97401    97481      +80     
+ Partials                     7676     7657      -19     
Flag Coverage Δ
go-unit-tests 49.63% <75.78%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ksurabhi91 ksurabhi91 marked this pull request as ready for review April 15, 2026 16:32
@ksurabhi91 ksurabhi91 requested a review from a team as a code owner April 15, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant