restore-shell-readlines-semicolon#645
Merged
general-kroll-4-life merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
general-kroll-4-life
force-pushed
the
bugfix/semicolon-restore
branch
from
1412c77 to
4a72665
Compare
Summary: - Restore semicolons to appropriate places in `readlines` buffer from `stackql shell` sessions. - Fix multiline query handling. - `--approot` passing in test fix, in support of `readlines` buffer checking. `readlines` check skipped for `docker` tests. - Added robot test `Shell Session Multi Line Then Multi Statement`. - Tested correct semicolon placement in enhanced robot test `Shell Session Multiple Statements Inline`. - Skip `readline` verification in docker for now.
general-kroll-4-life
force-pushed
the
bugfix/semicolon-restore
branch
from
ac8e5e4 to
2d5e1c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
readlinesbuffer fromstackql shellsessions.--approotpassing in test fix, in support ofreadlinesbuffer checking.readlinescheck skipped fordockertests.Shell Session Multi Line Then Multi Statement.Shell Session Multiple Statements Inline.readlineverification in docker for now.Type of change
Issues referenced.
N/A.
Evidence
Shell Session Multi Line Then Multi Statement.Shell Session Multiple Statements Inline.Checklist:
Variations
N/A.
Tech Debt
No technical debt is introduced in this change.