Merged
Conversation
Summary: - Correction of `left join` from defective `inner join` implementation to proper `left outer join` implementation. - Updated robot test `Subquery Left Joined With Aliasing and Name Collision`. - Updated robot test `Inner Join Users Cross Cloud Fuzzy Match`. - Added robot test `Inner Join Negative LHS Inline`. - Added robot test `Inner Join Positive LHS Inline`. - Added robot test `Left Join Negative LHS Inline`. - Added robot test `Left Join Positive LHS Inline`. - Added robot test `View Left Join View Returns Results`. - Added robot test `View Left Join Subquery Returns Results`. - Added robot test `View Left Join Materialized View Returns Results`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
left joinfrom defectiveinner joinimplementation to properleft outer joinimplementation.Subquery Left Joined With Aliasing and Name Collision.Inner Join Users Cross Cloud Fuzzy Match.Inner Join Negative LHS Inline.Inner Join Positive LHS Inline.Left Join Negative LHS Inline.Left Join Positive LHS Inline.View Left Join View Returns Results.View Left Join Subquery Returns Results.View Left Join Materialized View Returns Results.Type of change
Issues referenced.
Closes #642
Evidence
Subquery Left Joined With Aliasing and Name Collision.Inner Join Users Cross Cloud Fuzzy Match.Inner Join Negative LHS Inline.Inner Join Positive LHS Inline.Left Join Negative LHS Inline.Left Join Positive LHS Inline.View Left Join View Returns Results.View Left Join Subquery Returns Results.View Left Join Materialized View Returns Results.Checklist:
Variations
N/A.
Tech Debt
No technical debt is added in this change.