Merged
Conversation
Summary: - Support for **limited** composition of indirects, including `view`, `materialized view`, subqueries and user space tables. - Uplift compound query string splitting from naive prior state to instead use existing parser function `SplitStatementToPieces()`. - View documentation updated in `docs/views.md`. - Added robot test `View Depth Limitation Error Message Shows Correct Max`. - Added robot test `View JOIN View Returns Results`. - Added robot test `View JOIN Provider Table Returns Results`. - Added robot test `Subquery JOIN Subquery Returns Results`. - Added robot test `CTE Within View Returns Results`. - Added robot test `Shell Session Multiple Statements Inline`. - Added robot test `Shell Session Multi Line Then Multi Statement`. - Added robot test `View JOIN Materialized View Returns Results`. - Added robot test `View JOIN Subquery Returns Results`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
view,materialized view, subqueries and user space tables.SplitStatementToPieces().docs/views.md.View Depth Limitation Error Message Shows Correct Max.View JOIN View Returns Results.View JOIN Provider Table Returns Results.Subquery JOIN Subquery Returns Results.CTE Within View Returns Results.Shell Session Multiple Statements Inline.Shell Session Multi Line Then Multi Statement.View JOIN Materialized View Returns Results.View JOIN Subquery Returns Results.Type of change
Issues referenced.
Partial fulfillment of #629
Evidence
View Depth Limitation Error Message Shows Correct Max.View JOIN View Returns Results.View JOIN Provider Table Returns Results.Subquery JOIN Subquery Returns Results.CTE Within View Returns Results.Shell Session Multiple Statements Inline.Shell Session Multi Line Then Multi Statement.View JOIN Materialized View Returns Results.View JOIN Subquery Returns Results.Checklist:
Variations
N/A.
Tech Debt
No technical debt is introduced in this change. It is a step towards retiring existing technical debt.