perf: enforce budgets and isolate the live lab - #23
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5d0a7a15a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const repositoryBeta = /^(\d+\.\d+\.\d+)-beta\.(\d+)$/.exec(repositoryVersion); | ||
| const liveLabBeta = /^(\d+\.\d+\.\d+)-beta\.(\d+)$/.exec(liveLabVersion); | ||
| if (!repositoryBeta || !liveLabBeta || repositoryBeta[1] !== liveLabBeta[1]) { |
There was a problem hiding this comment.
When the package is promoted from a beta to a stable version such as 1.0.0, repositoryBeta is null and this verifier always throws. The inspected release workflow runs pnpm check—which includes this verifier—before publishing, even though that workflow explicitly supports stable releases via the latest channel, so the first stable release cannot pass its release gate.
Useful? React with 👍 / 👎.
| .card-heading h2 { margin-bottom: 0; font-size: 26px; letter-spacing: -0.04em; } | ||
| .status-dot::before { width: 7px; height: 7px; margin-right: 7px; border-radius: 50%; background: #77736f; content: ""; } | ||
| .status-dot--ready { color: #a9e9c7; } | ||
| .status-dot--ready::before { background: #42d392; box-shadow: 0 0 12px rgba(66,211,146,0.6); } |
There was a problem hiding this comment.
When the fixture reaches its ready state, this rule introduces a saturated green status indicator, making the live lab depart from the repository's required visual system in which #ff385c is the only saturated accent. Use the established pink accent treatment rather than adding a second status hue.
AGENTS.md reference: AGENTS.md:L8-L8
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
pnpm check