Skip to content

Signal SIGUSR2 not available on Windows #5

Open

Description

@Tezar

For development we use some boxes with Windows. Currently trying to include start agent on Windows produces self-explaining error

File "...\stackimpact\agent.py", line 113, in start register_signal(signal.SIGUSR2, _signal_handler) AttributeError: module 'signal' has no attribute 'SIGUSR2'

Is it safe to disable this signaling for Win? Unfortunately I am not sure for what is actually SIGUSR2 used in stackimpact so not providing PR.

Activity

  1. dmelikyan commented on Oct 2, 2017

    @dmelikyan
    Member

    The OS check was missing in the allocation profiler. I've just pushed a fix for it. Please get the latest agent.

    FYI, SIGUSR2 is transparently used as a way to initiate allocation profiler on the main thread from timer threads.

  2. Tezar commented on Oct 2, 2017

    @Tezar
    Author

    Hi,
    thanksfor fast fix. Unfortunately it's still failing with same error. Problem occurs immediately when starting agent.
    Tried version 1.1.3 ca08a03

  3. dmelikyan commented on Oct 2, 2017

    @dmelikyan
    Member

    That's right, a few more things were actually necessary. Please try the latest. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions