Skip to content

Synchronise 2023.1 with upstream#84

Merged
priteau merged 2 commits intostackhpc/2023.1from
upstream/2023.1-2024-09-30
Sep 30, 2024
Merged

Synchronise 2023.1 with upstream#84
priteau merged 2 commits intostackhpc/2023.1from
upstream/2023.1-2024-09-30

Conversation

@github-actions
Copy link
Copy Markdown

This PR contains a snapshot of 2023.1 from upstream stable/2023.1.

juliakreger and others added 2 commits May 3, 2024 17:57
If this seems like deja vu, that is because it is. We had this
very same issue with the original CoreOS ramdisk. Since we don't
control the whole OS of the ramdisk, it only made sense to teach
the agent to umount the folder.

The folder is referenced already, and the agent does have safeguards
in place, but unfortunately this issue led to a rebuild breaking where
cloud-init, glean, and the agent were all trying do the right thing
as they thought, and there were just multiple /mnt/config folders
present in the OS. These are separate issues we also need to try and
remedy.

What happens is when the device is locked via a mount, the partition
table is never updated to the running OS as the mount creates a lock.
So the agent ends up thinking, in the case of a rebuild, that everything
including creating a configuration drive on that device has been
successful, but when you reboot, there is no partition table entry
for the new partition as the change was not successfully written.
This state prevented the workload from rebooting properly.
This change eliminates that possibility moving forward by attempting
to ensure that the cloud configuration folder is no longer mounted.

Depends-On: https://review.opendev.org/c/openstack/ironic/+/918118
Change-Id: I4399dd0934361003cca9ff95a7e3e3ae9bba3dab
(cherry picked from commit 6ac3f35)
(cherry picked from commit 0337474)
@github-actions github-actions bot requested a review from a team as a code owner September 30, 2024 06:23
@github-actions github-actions bot added automated Automated action performed by GitHub Actions synchronisation labels Sep 30, 2024
@priteau priteau closed this Sep 30, 2024
@priteau priteau reopened this Sep 30, 2024
@priteau priteau merged commit 07bb6fa into stackhpc/2023.1 Sep 30, 2024
@priteau priteau deleted the upstream/2023.1-2024-09-30 branch September 30, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated Automated action performed by GitHub Actions synchronisation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants