Skip to content

fix(helm-sys): Double the helm timeout after reported timeout errors#306

Merged
NickLarsenNZ merged 2 commits into
mainfrom
fix/double-timeout
Jun 26, 2024
Merged

fix(helm-sys): Double the helm timeout after reported timeout errors#306
NickLarsenNZ merged 2 commits into
mainfrom
fix/double-timeout

Conversation

@NickLarsenNZ
Copy link
Copy Markdown
Member

@NickLarsenNZ NickLarsenNZ commented Jun 25, 2024

Description

There have been multiple reports of errors when deploying to some clusters.

image

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@NickLarsenNZ NickLarsenNZ self-assigned this Jun 25, 2024
@NickLarsenNZ NickLarsenNZ enabled auto-merge June 25, 2024 16:04
razvan
razvan reviewed Jun 25, 2024
View reviewed changes
Comment thread rust/helm-sys/go-helm-wrapper/main.go
@razvan razvan requested a review from a team June 25, 2024 16:15
@NickLarsenNZ NickLarsenNZ requested review from Techassi and razvan June 26, 2024 07:38
razvan
razvan approved these changes Jun 26, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's worth a try.

@NickLarsenNZ
Copy link
Copy Markdown
Member Author

NickLarsenNZ commented Jun 26, 2024

I guess it's worth a try.

That's the spirit 😄

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit c55f692 Jun 26, 2024
@NickLarsenNZ NickLarsenNZ deleted the fix/double-timeout branch June 26, 2024 08:15
@Techassi Techassi mentioned this pull request Jul 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@razvan razvan razvan approved these changes

@Techassi Techassi Awaiting requested review from Techassi

Assignees

@NickLarsenNZ NickLarsenNZ

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NickLarsenNZ @razvan @Techassi