Skip to content

Release 24.7 changes/fixes#80

Merged
maltesander merged 13 commits into
mainfrom
release-24-7-fixes
Jul 25, 2024
Merged

Release 24.7 changes/fixes#80
maltesander merged 13 commits into
mainfrom
release-24-7-fixes

Conversation

@maltesander
Copy link
Copy Markdown
Member

@maltesander maltesander commented Jul 23, 2024

  • fix some typos
  • fix heading levels
  • enable syntax formatting
  • replace the -p (push branches and tags) option with a comment for enabling it after testing
  • explicitly sign commits and tags (per Stackable handbook)
  • add make regenerate-nix so the Cargo.nix is updated with the release version
  • run make commands in a nix-shell (per operator, to pickup necessary dependencies)
    • This should not affect anyone, as make already requires nix to be available.
  • add a nix-shell with dependencies necessary to run the scripts
  • convert asciidoc to markdown (to be consistent with the other READMEs)
  • add links from main readme

NickLarsenNZ
NickLarsenNZ previously approved these changes Jul 23, 2024
Copy link
Copy Markdown
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander maltesander marked this pull request as ready for review July 25, 2024 08:01
@NickLarsenNZ NickLarsenNZ self-requested a review July 25, 2024 08:11
Copy link
Copy Markdown
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander maltesander added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit 15dede2 Jul 25, 2024
@maltesander maltesander deleted the release-24-7-fixes branch July 25, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants