feat(stackable-telemetry)!: Allow customization of the rolling file appender#995
Merged
NickLarsenNZ merged 8 commits intoApr 1, 2025
Merged
Conversation
…pender rotation period
NickLarsenNZ
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
NickLarsenNZ
changed the title
NickLarsenNZ
changed the title
Techassi
reviewed
Apr 1, 2025
Techassi
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Techassi
approved these changes
Apr 1, 2025
NickLarsenNZ
moved this from Development: In Review
to Development: Done
in Stackable Engineering
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 1, 2025
…ppender (#995) * feat(stackable-telemetry): Allow customization of the rolling file appender rotation period * chore(stackable-telemetry): Update changelog * feat(stackable-telemetry): Add required file appender filename_suffix field * feat(stackable-telemetry): Allow customization of the rolling file appender max log files * chore(stackable-telemetry): Mark change as breaking * feat(stackable-telemetry): Complete the sentence * feat(stackable-telemetry): Add punctuation * chore(stackable-telemetry): Replace generic parameters with impls
NickLarsenNZ
deleted the
feat/stackable-telemetry-file-appender-rotation-period
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/issues#639.
filename_suffixfield.Never).Definition of Done Checklist