Skip to content

fix(stackable-versioned): Emit correct enum based on kube kind argument#920

Merged
Techassi merged 3 commits into
mainfrom
fix/stackable-versioned-kubernetes-kind
Nov 28, 2024
Merged

fix(stackable-versioned): Emit correct enum based on kube kind argument#920
Techassi merged 3 commits into
mainfrom
fix/stackable-versioned-kubernetes-kind

Conversation

@Techassi
Copy link
Copy Markdown
Member

@Techassi Techassi commented Nov 28, 2024

Part of stackabletech/issues#642

The enum used to generate the merged CRD function now uses the correct ident if customized via #[kube/k8s(kind = "MyName")].

@Techassi Techassi self-assigned this Nov 28, 2024
@Techassi Techassi marked this pull request as ready for review November 28, 2024 14:42
Copy link
Copy Markdown
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit 11c4092 Nov 28, 2024
@Techassi Techassi deleted the fix/stackable-versioned-kubernetes-kind branch November 28, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants