Skip to content

refactor!: Replace unmaintained derivative create with educe#907

Merged
sbernauer merged 8 commits into
mainfrom
refactor/remove-derivative
Nov 28, 2024
Merged

refactor!: Replace unmaintained derivative create with educe#907
sbernauer merged 8 commits into
mainfrom
refactor/remove-derivative

Conversation

@sbernauer
Copy link
Copy Markdown
Member

@sbernauer sbernauer commented Nov 18, 2024 •
edited
Loading

Description

Fixes #905
Part of stackabletech/issues#677

Also updated deny.toml to match the one in operator-templating.

We still have the instant and rsa crates, but that will be separate PRs.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)

# Reviewer
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@siegfriedweber siegfriedweber self-requested a review November 19, 2024 07:04
siegfriedweber
siegfriedweber requested changes Nov 19, 2024
View reviewed changes
Comment thread crates/stackable-operator/CHANGELOG.md Outdated
Comment thread crates/stackable-operator/src/crd.rs Outdated
Comment thread deny.toml
@sbernauer sbernauer mentioned this pull request Nov 19, 2024
Merged
NickLarsenNZ
NickLarsenNZ reviewed Nov 22, 2024
View reviewed changes
Comment thread Cargo.toml
@sbernauer
Copy link
Copy Markdown
Member Author

sbernauer commented Nov 26, 2024

@siegfriedweber given #907, are we ready to merge this and follow-up on the OpenSSL license in https://github.com/stackabletech/decisions/issues/35?

@sbernauer sbernauer mentioned this pull request Nov 28, 2024
Closed
6 tasks
@sbernauer sbernauer added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit 1b7de87 Nov 28, 2024
@sbernauer sbernauer deleted the refactor/remove-derivative branch November 28, 2024 07:53
@Techassi Techassi mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soenkeliebau soenkeliebau soenkeliebau left review comments

@NickLarsenNZ NickLarsenNZ NickLarsenNZ left review comments

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RUSTSEC-2024-0388: derivative is unmaintained; consider using an alternative

4 participants

@sbernauer @soenkeliebau @NickLarsenNZ @siegfriedweber