Skip to content

fix(stackable-versioned): Validation error reporting#842

Merged
Techassi merged 7 commits into
mainfrom
fix/crd-versioning-validation-errors
Aug 21, 2024
Merged

fix(stackable-versioned): Validation error reporting#842
Techassi merged 7 commits into
mainfrom
fix/crd-versioning-validation-errors

Conversation

@Techassi
Copy link
Copy Markdown
Member

@Techassi Techassi commented Aug 21, 2024

This fixes two issues:

  • Variant rename validation errors showed up at the wrong place. It now used the span of the variant ident.
  • Variants not using PascalCase (for example: My_Variant) included the leading underscore in the generated variant name.
# Reviewer
- [ ] Code contains useful comments
- [ ] Changelog updated

@Techassi Techassi self-assigned this Aug 21, 2024
NickLarsenNZ
NickLarsenNZ previously approved these changes Aug 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread crates/stackable-versioned-macros/src/codegen/common/mod.rs Outdated
Comment thread crates/stackable-versioned-macros/src/codegen/common/mod.rs Outdated
Comment thread crates/stackable-versioned-macros/src/codegen/common/mod.rs Outdated
@Techassi Techassi requested a review from NickLarsenNZ August 21, 2024 09:46
NickLarsenNZ
NickLarsenNZ requested changes Aug 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 chainzes

Comment thread crates/stackable-versioned-macros/src/codegen/common/mod.rs Outdated
Comment thread crates/stackable-versioned-macros/src/codegen/common/mod.rs Outdated
@Techassi @NickLarsenNZ
chore: Apply suggestions
87cc5be 
This snuck in because rust-analyzer doesn't remove trailing commas the same way it does for the format! macro.

Co-authored-by: Nick <[email protected]>
@Techassi Techassi requested a review from NickLarsenNZ August 21, 2024 09:50
NickLarsenNZ
NickLarsenNZ approved these changes Aug 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi enabled auto-merge August 21, 2024 09:51
@Techassi Techassi added this pull request to the merge queue Aug 21, 2024
Merged via the queue into main with commit 79252b2 Aug 21, 2024
@Techassi Techassi deleted the fix/crd-versioning-validation-errors branch August 21, 2024 10:07
@Techassi Techassi mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@Techassi Techassi

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Techassi @NickLarsenNZ