Skip to content

refactor(stackable-versioned): Remove duplicate code#820

Merged
Techassi merged 12 commits into
mainfrom
refactor/crd-versioning-remove-duplicate-code
Aug 19, 2024
Merged

refactor(stackable-versioned): Remove duplicate code#820
Techassi merged 12 commits into
mainfrom
refactor/crd-versioning-remove-duplicate-code

Conversation

@Techassi
Copy link
Copy Markdown
Member

@Techassi Techassi commented Jun 28, 2024 •
edited
Loading

Part of stackabletech/issues#507

This PR unifies struct/enum and field/variant code. This allows common parts to be shared and only implemented once. Currently blocked until #813 is merged.

# Reviewer
- [ ] Code contains useful comments
- [x] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

@Techassi Techassi self-assigned this Jun 28, 2024
@Techassi Techassi mentioned this pull request Jun 28, 2024
Closed
NickLarsenNZ
NickLarsenNZ reviewed Aug 19, 2024
View reviewed changes
Comment thread crates/stackable-versioned-macros/src/lib.rs
NickLarsenNZ
NickLarsenNZ previously approved these changes Aug 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread crates/stackable-versioned-macros/src/codegen/vstruct/field.rs Outdated
Comment thread crates/stackable-versioned-macros/src/codegen/vstruct/field.rs Outdated
Comment thread crates/stackable-versioned-macros/src/codegen/vstruct/field.rs
Comment thread crates/stackable-versioned-macros/src/codegen/vstruct/field.rs Outdated
Comment thread crates/stackable-versioned-macros/src/codegen/common/item.rs Outdated
Comment thread crates/stackable-versioned-macros/src/codegen/common/item.rs Outdated
Comment thread crates/stackable-versioned-macros/src/codegen/common/item.rs Outdated
Comment thread crates/stackable-versioned-macros/src/codegen/chain.rs Outdated
Comment thread crates/stackable-versioned-macros/src/attrs/variant.rs Outdated
Comment thread crates/stackable-versioned-macros/src/attrs/common/item.rs
@Techassi Techassi requested a review from NickLarsenNZ August 19, 2024 14:10
NickLarsenNZ
NickLarsenNZ approved these changes Aug 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Aug 19, 2024
Merged via the queue into main with commit cee9bd5 Aug 19, 2024
@Techassi Techassi deleted the refactor/crd-versioning-remove-duplicate-code branch August 19, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@Techassi Techassi

Labels

type/internal-improvement

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Techassi @NickLarsenNZ