Skip to content

[Merged by Bors] - test fixes#426

Closed
fhennig wants to merge 1 commit into
mainfrom
fix/docs-test-nightly-to-dev2
Closed

[Merged by Bors] - test fixes#426
fhennig wants to merge 1 commit into
mainfrom
fix/docs-test-nightly-to-dev2

Conversation

@fhennig
Copy link
Copy Markdown
Contributor

@fhennig fhennig commented Mar 10, 2023 •
edited
Loading

Description

test https://ci.stackable.tech/view/05%20Documentation%20Tests/job/opa-operator-documentation-test/13/

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@fhennig fhennig mentioned this pull request Mar 10, 2023
Closed
19 tasks
maltesander
maltesander approved these changes Mar 10, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread docs/modules/opa/examples/getting_started/getting_started.sh.j2

echo "Waiting on rollout ..."
kubectl rollout status --watch daemonset/simple-opa-server-default
kubectl rollout status --watch --timeout=5m daemonset/simple-opa-server-default
Copy link
Copy Markdown
Member

@maltesander maltesander Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5m timeout for opa seems overkill unless you are using a 56k modem ;)

@fhennig
Copy link
Copy Markdown
Contributor Author

fhennig commented Mar 13, 2023

bors merge

bors Bot pushed a commit that referenced this pull request Mar 13, 2023
test fixes (#426)
368c57a 
# Description

test https://ci.stackable.tech/view/05%20Documentation%20Tests/job/opa-operator-documentation-test/13/
@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Mar 13, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors Bot changed the title test fixes [Merged by Bors] - test fixes Mar 13, 2023
@bors bors Bot closed this Mar 13, 2023
@bors bors Bot deleted the fix/docs-test-nightly-to-dev2 branch March 13, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fhennig @maltesander