feat: remove product config & clean up#765
Open
maltesander wants to merge 18 commits into
Open
Conversation
Activate the operator-rs smooth-operator patch (matching trino/hdfs) and add a vendored Hadoop XML / Java-properties writer copied from hdfs-operator, so the operator no longer needs product-config for rendering. Reroute discovery and the controller to the vendored writer. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Add name (ClusterName) and a ValidatedClusterConfig, rename role_groups to role_group_configs, and add merged config_overrides/env_overrides per role group. The product_config_properties map is kept temporarily so the existing config-map path still compiles. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Add per-file builders (hbase-site, hbase-env, ssl-server, ssl-client, security.properties) and a config_map orchestrator that render from the validated cluster, plus unit tests. Defaults previously sourced from properties.yaml (cluster distributed, role-specific DNS TTLs, HBASE_MANAGES_ZK) are now in code. Not yet wired into reconcile. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Wire reconcile to the new controller/build config_map orchestrator, build container env from validated env_overrides instead of the product-config Env map, and delete the old PropertyNameKind-based config-map and hbase-env.sh builders. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Drop ProductConfigManager / transform_all_roles_to_config / validate_all_roles_and_groups_config from the validate step, remove the Configuration trait impls and build_role_properties from the CRD, delete the now-unused product_config_properties field and the Ctx.product_config field, and stop loading the product config in main.rs. The product-config crate is now unreferenced in source. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Empty config-spec/properties.yaml (mirroring trino/opensearch/hdfs) and drop the product-config crate from both Cargo manifests. The operator now renders all config from typed, validated inputs; product-config remains only as a transitive dependency of stackable-operator. Also remove the stale product-config CLI/env-var docs. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Pre-resolve kerberos/TLS settings + kerberos flag (ValidatedClusterConfig) and the role-specific non-heap JVM args (ValidatedRoleGroupConfig) during validate, so the hbase-site/hbase-env/ssl-server/ssl-client builders render purely from the validated cluster. The config_map orchestrator still uses HbaseCluster only for the ConfigMap owner reference/metadata (to be decoupled in a follow-up). Rename validated -> validated_cluster. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
16 tasks
Member
|
CRD is backwards compatible (as of now). Tested operator upgrade with the getting started script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker