fix: Update demos and documentation#57
Conversation
xeniape
changed the title
…d-cycling-data demos
xeniape
changed the title
sbernauer
changed the title
sbernauer
left a comment
sbernauer
left a comment
There was a problem hiding this comment.
Thanks! FYI, I changed the PR title (it will be the commit message), I hope that's ok
sbernauer
changed the title
fhennig
left a comment
fhennig
left a comment
There was a problem hiding this comment.
Looks good!
I just put the sentences on individual lines.
Co-authored-by: Felix Hennig <[email protected]>
…tion-taxi-data.adoc Co-authored-by: Felix Hennig <[email protected]>
…tion-taxi-data.adoc Co-authored-by: Felix Hennig <[email protected]>
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
There was a problem hiding this comment.
Some of the images are smaller than before. Just check what that looks like in the rendered site.
Thanks for the idea! Tried it with local rendering and it looked fine to me. If someone else wants to try it and has some feedback though, I can update the screenshots as well. |
maltesander
left a comment
maltesander
left a comment
There was a problem hiding this comment.
Awesome work thank you :) Just minor things...
|
I'm ok with the images sizes, though some of the text is on the smaller side. We will add some tips for doing this in the new issue templates for the release process: stackabletech/issues#602 |
Co-authored-by: Malte Sander <[email protected]>
6 participants
Some demo configurations (MinIO service name and Druid Middlemanager resources), commands (Kafka probing and SQL queries) and product UIs were outdated / defective. This PR fixes them. Also fixes minor typos and adds consistency between the two nifi-kafka-druid demos.
Extending this PR to other demos and their documentation as well. Similar tasks of updating screenshots, typos etc.