ci: deploy Stack-chan WASM simulator#403
ci: deploy Stack-chan WASM simulator#403meganetaaan wants to merge 9 commits intofeat/wasm-stackchan-buildfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 64f849089e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (kind === 0) this.tracking += event.changedTouches.length | ||
| if (kind === 1 || kind === 2) this.tracking -= event.changedTouches.length | ||
| for (const touch of event.changedTouches) { | ||
| this.#touch(kind, touch.identifier, touch.pageX, touch.pageY, event.timeStamp) |
There was a problem hiding this comment.
#touches forwards touch.pageX/pageY into #touch, which then subtracts getBoundingClientRect() offsets. Because pageX/pageY include document scroll while getBoundingClientRect() is viewport-relative, touch coordinates are shifted whenever the page is scrolled (a common mobile case given this page layout), so fxMainTouch receives incorrect positions and taps map to the wrong screen location. Use touch.clientX/clientY (or compensate with window.scrollX/scrollY) before forwarding.
Useful? React with 👍 / 👎.
…ci/deploy-wasm-stackchan-web
…ci/deploy-wasm-stackchan-web
…ci/deploy-wasm-stackchan-web
…ci/deploy-wasm-stackchan-web
…ci/deploy-wasm-stackchan-web
…ci/deploy-wasm-stackchan-web
1 participant
Summary
Stacking
Verification
/.local/share/moddable + emsdk 3.1.2 + FONTBM=/.local/bin/fontbm npm run build:wasmDo not merge until the base WASM build-support PR is ready. No auto-merge requested.