chore: add root editorconfig defaults#380
Conversation
📝 WalkthroughWalkthroughA new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.editorconfig (1)
3-9: Configuration covers main web files, but shell scripts are uncovered.The configuration properly covers web/text file types (JS, TS, JSON, YAML, HTML, CSS) with appropriate defaults. However, shell scripts (
.shfiles) exist infirmware/docker/but are not included in the file pattern.Consider adding shell scripts to the coverage:
[*.{js,ts,json,jsonc,yml,yaml,html,css,mjs,sh}]This ensures consistent formatting standards across all configuration and deployment scripts.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.editorconfig around lines 3 - 9, Update the [*.{js,ts,json,jsonc,yml,yaml,html,css,mjs}] file pattern in .editorconfig to include shell scripts so .sh files in firmware/docker/ are covered; edit the existing file pattern (the line starting with [*.{js,ts,json,jsonc,yml,yaml,html,css,mjs}]) to add "sh" into the brace list (i.e., expand the glob to include sh) so the existing rules (charset, end_of_line, indent_style, indent_size, insert_final_newline, trim_trailing_whitespace) apply to shell scripts as well.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.editorconfig:
- Around line 3-9: Update the [*.{js,ts,json,jsonc,yml,yaml,html,css,mjs}] file
pattern in .editorconfig to include shell scripts so .sh files in
firmware/docker/ are covered; edit the existing file pattern (the line starting
with [*.{js,ts,json,jsonc,yml,yaml,html,css,mjs}]) to add "sh" into the brace
list (i.e., expand the glob to include sh) so the existing rules (charset,
end_of_line, indent_style, indent_size, insert_final_newline,
trim_trailing_whitespace) apply to shell scripts as well.
1 participant
Adds a repository-level .editorconfig so common text formats follow consistent line ending, indentation, and trailing-whitespace defaults.
Summary by CodeRabbit