fix: restore firmware test and biome scripts#377
fix: restore firmware test and biome scripts#377meganetaaan wants to merge 1 commit intodev/v1.0from
Conversation
📝 WalkthroughWalkthroughThis PR refines the test build configuration and npm scripts to enforce JavaScript imports in test compilation and narrows the scope of code quality commands. It updates the TypeScript test configuration to disallow Changes
Possibly Related PRs
Poem
🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
firmware/package.json (1)
16-16: Consider recursive test globs for future resilience if test structure changes.The current non-recursive globs (
*.test.js) will miss any nested test files. While no nested tests currently exist intests/unitorstackchan/drivers/__tests__, using**/*.test.jsis safer if the test layout evolves.♻️ Suggested update
- "test:unit": "rm -rf dist-tests && tsc --project tsconfig.test.json && node --test dist-tests/tests/unit/*.test.js dist-tests/stackchan/drivers/__tests__/*.test.js", + "test:unit": "rm -rf dist-tests && tsc --project tsconfig.test.json && node --test dist-tests/tests/unit/**/*.test.js dist-tests/stackchan/drivers/__tests__/**/*.test.js",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@firmware/package.json` at line 16, Update the "test:unit" npm script so it uses recursive globs to pick up nested test files: replace the non-recursive patterns (*.test.js) with recursive patterns (**/*.test.js) in the "test:unit" script entry in package.json so both dist-tests/tests/unit and dist-tests/stackchan/drivers/__tests__ will include tests in subdirectories.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@firmware/package.json`:
- Line 16: Update the "test:unit" npm script so it uses recursive globs to pick
up nested test files: replace the non-recursive patterns (*.test.js) with
recursive patterns (**/*.test.js) in the "test:unit" script entry in
package.json so both dist-tests/tests/unit and
dist-tests/stackchan/drivers/__tests__ will include tests in subdirectories.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 223f614e-e088-4f9e-8c1f-f33e8f08c743
📒 Files selected for processing (3)
firmware/package.jsonfirmware/stackchan/drivers/__tests__/single-wait-slot.test.tsfirmware/tsconfig.test.json
1 participant
Restores firmware test execution and scopes Biome to repository files so CI checks can run reliably. Verified with cd firmware && npm run format, npm run lint, and npm run test.
Summary by CodeRabbit