Skip to content

Work around latest Moddable XS_MODS linker regression#375

Open
meganetaaan wants to merge 1 commit intomeganetaaan/issue-373-latest-typingsfrom
meganetaaan/issue-373-xs-mods-workaround
Open

Work around latest Moddable XS_MODS linker regression#375
meganetaaan wants to merge 1 commit intomeganetaaan/issue-373-latest-typingsfrom
meganetaaan/issue-373-xs-mods-workaround

Conversation

@meganetaaan
Copy link
Copy Markdown
Collaborator

@meganetaaan meganetaaan commented Mar 15, 2026

Summary

  • add an ESP32-only weak fallback definition for gXSAbortStrings
  • include that fallback in the utility manifest so XS_MODS hosts link again on the latest Moddable public branch

Notes

  • Stacked on Align firmware typings with latest Moddable #374.
  • This is a downstream temporary workaround for the current upstream regression where xs/platforms/mc/xsHosts.c references gXSAbortStrings as an external symbol while xs/sources/xsError.c keeps that table file-local.
  • This shim should be removed once the upstream fix lands.

Verification

  • npm run build
  • npm run build --target=esp32/m5stack_cores3
  • npm run format
  • npm run lint

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 15, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 56c94b67-89bf-4298-8b43-efa6aef05095

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch meganetaaan/issue-373-xs-mods-workaround
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable sequence diagrams in the walkthrough.

Disable the reviews.sequence_diagrams setting to disable sequence diagrams in the walkthrough.

@meganetaaan meganetaaan mentioned this pull request Apr 26, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@meganetaaan