Skip to content

Align firmware typings with latest Moddable#374

Draft
meganetaaan wants to merge 177 commits intodev/v1.0from
meganetaaan/issue-373-latest-typings
Draft

Align firmware typings with latest Moddable#374
meganetaaan wants to merge 177 commits intodev/v1.0from
meganetaaan/issue-373-latest-typings

Conversation

@meganetaaan
Copy link
Copy Markdown
Collaborator

Summary

  • update @moddable/typings to 7.2.0
  • register the latest Moddable web/* typings under the module names this firmware imports
  • load the repo typings manifest before Moddable's shared manifests so those aliases win
  • normalize the manifest paths used by the npm build scripts for the latest mcconfig

Notes

  • This is the typings-only part of CI build fails with latest Moddable public commit #373.
  • On the latest Moddable public branch, full ESP32 host builds are still blocked by a separate upstream XS_MODS linker regression.
  • The downstream temporary workaround for that regression is proposed separately in a stacked PR.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 15, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f8456096-bed6-4ae6-b074-63c4519b197f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch meganetaaan/issue-373-latest-typings
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable poems in the walkthrough.

Disable the reviews.poem setting to disable the poems in the walkthrough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant