step 8/8: スタートアップ画面にセットアップ導線を追加#369
step 8/8: スタートアップ画面にセットアップ導線を追加#369meganetaaan wants to merge 4 commits intostep-pr/07-dynamixel-driver-speedupfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 398bebc1d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const wifiResult = await checkAndConnectWiFi().catch((msg) => { | ||
| startupScreen.setStatus(`Wi-Fi connection failed: ${String(msg)}`) | ||
| return 'failed' | ||
| }) |
There was a problem hiding this comment.
The setup path is checked only once before entering the Wi-Fi branch, then await checkAndConnectWiFi() blocks; if the user taps the setup button while this await is in progress, that request is not observed until after connect returns. This means the new startup setup flow can be significantly delayed (or effectively blocked on flaky networks), even though the UI says setup is opening, so setup should be re-checked/cancellable while waiting for Wi-Fi.
Useful? React with 👍 / 👎.
meganetaaan
force-pushed
the
step-pr/08-startup-screen-setup
branch
from
86853bf to
7b6aa45
Compare
2 participants
Summary
Stacked Base