use Helm values files#250
Merged
Merged
Conversation
meyskens
force-pushed
the
helm-values-file
branch
from
c13cb5b to
8ad2404
Compare
rporres
approved these changes
Oct 17, 2018
rporres
left a comment
rporres
left a comment
There was a problem hiding this comment.
Once merge conflicts are solved, LGTM :)
Signed-off-by: Maartje Eyskens <[email protected]>
meyskens
force-pushed
the
helm-values-file
branch
from
8ad2404 to
e2845f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maartje Eyskens [email protected]
Is like #245 but using values files since drone-helm escapes quotes incorrect.