Skip to content

Upload endpoint#188

Merged
smacker merged 2 commits into
src-d:masterfrom
smacker:upload_endpoint
Mar 1, 2018
Merged

Upload endpoint#188
smacker merged 2 commits into
src-d:masterfrom
smacker:upload_endpoint

Conversation

@smacker

@smacker smacker commented Mar 1, 2018

Copy link
Copy Markdown
Contributor

Implements endpoint for #160

@smacker smacker requested a review from bzz March 1, 2018 13:04
smacker added 2 commits March 1, 2018 15:22
Signed-off-by: Maxim Sukharev <[email protected]>
Signed-off-by: Maxim Sukharev <[email protected]>
@smacker smacker mentioned this pull request Mar 1, 2018
5 tasks

@dpordomingo dpordomingo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

if _, err := io.Copy(tmpfile, file); err != nil {
return nil, fmt.Errorf("can't copy content to tmp db file %s", err)
}
if err := tmpfile.Close(); err != nil {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\n missing

@dpordomingo

dpordomingo commented Mar 1, 2018

Copy link
Copy Markdown
Contributor

@smacker you can rebase/squash/merge

@smacker smacker merged commit f887212 into src-d:master Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants