Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roomie needs evidence that Node can host native DuckDB v2 over Quack and that DuckDB-Wasm can feed its existing chart renderer before choosing this transport for browserless cloud work. This draft preserves a reproducible experiment, a working source-build workaround, and the remaining implementation-plan checkpoints.
Stacked on #959 (
feat/duckdb-2-compatibility, originally inspected at8eb7a853ab98fa6c1dda6b7ac7832851fee0772f). Changes are confined toexperiments/quack-node-wasm/.Verified outcome
The remote browser histogram works using rebuilt httpfs and Quack extensions, the unmodified published
@duckdb/[email protected]threaded runtime, andmaximumThreads: 1.v2.0.0, 120 rows, total 12960. Arrow results feed the existing shared Roomie histogram renderer and produce nine visible bins.Upstream blockers and workaround
The published Wasm binaries are identical to the previously tested CI artifact. Strict loading still rejects their
d54cbbe3dfmetadata versus releasedv2.0.0extensions, and the default extension endpoint returns 404. The single-thread bundle cannot start Quack's heartbeat thread.Instrumenting the threaded loader exposes the hidden failure: the published
wasm_threadsextensions import non-shared memory while the runtime supplies shared memory. This matches extension-ci-tools #391 and duckdb-wasm #2041. A memory-only binary patch is insufficient here.Rebuilding both extensions from pinned sources with Emscripten 6.0.9, shared-memory flags, and matching engine headers gets them working. More than one query thread can still hang during extension loading; one query thread avoids that in the verified configuration while retaining the threaded runtime for heartbeat support.
THREADED-INVESTIGATION.mdrecords exact observations, the build recipe, existing upstream issues, and separate findings about missing error details and thread-count-dependent hangs.loader-probe.htmlreproduces the loader behavior without React, Mosaic, or Roomie. Upstream reports: v2 artifact reproduction on extension-ci-tools #391 and DuckDB-Wasm #2288: hidden loader errors and loading hang.Validation
main; that full build was not repeated in this stacked worktree.Production adoption still needs a compatible signed distribution, full Roomie integration, cancellation/reconnect/concurrency and access-policy tests, plus startup/memory measurements. Browserless workspace semantics and agent lifecycle remain separate work.