Repository navigation
fix(deck): stop capping new map fits at zoom 12 - #954
Draft
igorDykhta wants to merge 1 commit into
Draft
igorDykhta wants to merge 1 commit into
igorDykhta wants to merge 1 commit into
Conversation
Signed-off-by: Ihor Dykhta <[email protected]>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
igorDykhta
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fitToData, were savingmaxZoom: 12. That city-scale cap left small areas such as buildings and neighborhoods zoomed out.fitToData.maxZoomunless the saved config already has a number. An existing cap is kept when the geometry, longitude/latitude, or arc endpoints change. With the field omitted, fit-to-data still stops at zoom 18.Test plan
fitToDatashould havepaddingand nomaxZoom.fitToData.maxZoomto a low number such as 8, reload, and change the geometry column or the longitude/latitude columns. The fit should still stop at 8, andmaxZoomshould still be in the config.maxZoom, and on a new arc map that does not. The saved number stays; the new map does not gainmaxZoom: 12.