Skip to content

fix(deck): animate trip maps that use absolute timestamps - #953

Draft
igorDykhta wants to merge 1 commit into
mainfrom
igr/improve-animated-trips
Draft

fix(deck): animate trip maps that use absolute timestamps#953
igorDykhta wants to merge 1 commit into
mainfrom
igr/improve-animated-trips

Conversation

@igorDykhta

@igorDykhta igorDykhta commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Animated trip maps built from a DuckDB TIMESTAMP column never moved. Those values are epoch microseconds, the playhead starts at 0, and TripsLayer stores timestamps as Float32, which cannot tell the vertices apart.
  • Absolute timestamps are rebased to a short relative range in seconds before they are drawn. A short series such as [1, 2, 3] is left unchanged.

Test plan

  • Load a table of routes whose time column is a real timestamp (a DuckDB TIMESTAMP, or a list of them), not a small 0..N series.
  • Create a trips map on that table and confirm the paths move. Previously they sat still.
  • Use the timeline control: play, pause, and drag the slider. The range should match the trip duration, not an epoch-sized number.
  • Repeat with a dataset whose timestamps are already a short relative series, such as 0, 1, 2. The animation should look the same as before.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@igorDykhta igorDykhta changed the title fix(deck): improve animated timelines fix(deck): animate trip maps that use absolute timestamps Oct 19, 2026
@igorDykhta igorDykhta self-assigned this Oct 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

See More

@igorDykhta igorDykhta

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@igorDykhta