Repository navigation
fix: Use qualified table names in the SQL editor example - #833
Conversation
ilyabo
changed the title
📝 WalkthroughWalkthrough
ChangesQualified table names
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
examples/code-editor/src/SqlEditor.tsx (1)
22-22: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd a regression test for the helper-backed table metadata.
These calls replace the local
toStringandtoFullStringimplementations for theusersandordersmetadata. Add or update a focused test that verifies the canonical and fully qualified names used by autocomplete. Run the example's existing test or type-check command before merge.As per coding guidelines: add or update tests when changing behavior or public API, when practical. As per PR objective: keep autocomplete table schemas aligned with the shared DuckDB API.
Also applies to: 36-36
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@examples/code-editor/src/SqlEditor.tsx` at line 22, Add a focused regression test for the autocomplete table metadata created with makeQualifiedTableName, covering both users and orders and asserting their canonical and fully qualified names. Reuse the example’s existing test conventions and run its test or type-check command to verify the shared DuckDB API integration.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@examples/code-editor/src/SqlEditor.tsx`:
- Line 22: Add a focused regression test for the autocomplete table metadata
created with makeQualifiedTableName, covering both users and orders and
asserting their canonical and fully qualified names. Reuse the example’s
existing test conventions and run its test or type-check command to verify the
shared DuckDB API integration.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: cdc0a627-6c8f-46d1-8580-0f819cf67e72
📒 Files selected for processing (1)
examples/code-editor/src/SqlEditor.tsx
Summary
makeQualifiedTableNamein the SQL editor exampleTesting
Not run (not requested)
Summary by CodeRabbit