Repository navigation
feat: worksheet dashboard - #799
Closed
dmitriy-kostianetskiy wants to merge 7 commits into
Closed
dmitriy-kostianetskiy wants to merge 7 commits into
dmitriy-kostianetskiy wants to merge 7 commits into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughWalkthroughThis PR renames worksheet-scoped CLI artifacts (commands, AI adapters, AI tools, agent tools, and constants) to block-document-scoped equivalents throughout ChangesCLI worksheet-to-block-document rename
Estimated code review effort: 4 (Complex) | ~60 minutes ai dependency version bump
Estimated code review effort: 1 (Trivial) | ~5 minutes Sequence Diagram(s)sequenceDiagram
participant Agent as CliBlockDocumentAgentTool
participant Tools as createCliBlockDocumentAiTools
participant Commands as createCliBlockDocumentCommands
participant State as RoomState
Agent->>State: ensure/set current block document
Agent->>Tools: build tools with blockDocumentId
Tools->>Commands: invoke block-document.* command
Commands->>State: resolveBlockDocumentArtifact, create/update block
State-->>Commands: blockId, mapId, panelId
Commands-->>Tools: success result with blockDocumentId
Tools-->>Agent: tool execution result
Agent-->>Agent: return BlockDocumentAgentResult (blockDocumentId)
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7d45c221b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (2)
packages/documents/src/BlockDocumentEditor/BlockDocumentToolbar.tsx (1)
94-114: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider adding a test for the new dashboard insertion action.
This new toolbar button introduces a distinct interaction (insert a
blockDocumentStatefulBlockwith dashboard-specific attrs). If a test suite already exists for this toolbar's other buttons, consider adding a similar case for the dashboard button.As per coding guidelines, "Add or update tests when changing behavior or public API, when practical."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/documents/src/BlockDocumentEditor/BlockDocumentToolbar.tsx` around lines 94 - 114, The new dashboard toolbar action in BlockDocumentToolbar should be covered by tests similar to the existing toolbar button cases. Add or update a test that renders BlockDocumentToolbar, clicks the dashboard button, and verifies insertAtomBlock is called with blockDocumentStatefulBlock plus the dashboard-specific attrs such as blockType, ownership, title, caption, height, and a generated blockInstanceId. Use the existing toolbar test setup and any shared helpers/mocks around insertAtomBlock and generateBlockId to keep the test aligned with the current suite.Source: Coding guidelines
packages/ai-core/package.json (1)
50-50: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsider keeping a caret range instead of pinning
aiexactly.Pinning
"ai": "6.0.177"(no^) in a library package prevents package managers from deduping with other compatibleaiversions in a consumer's tree, which can cause duplicate installs of this dependency across packages/apps. Unless exact pinning is required to guarantee compatibility during this migration, consider restoring a caret range (e.g.^6.0.177).♻️ Suggested change
- "ai": "6.0.177", + "ai": "^6.0.177",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/ai-core/package.json` at line 50, The ai dependency in the package manifest is pinned exactly, which can prevent deduping across consumer trees. Update the dependency entry in package.json for ai to use a caret range instead of an exact version, unless this package explicitly requires a fixed pin for compatibility during the migration.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/ai-core/package.json`:
- Line 50: The ai dependency in the package manifest is pinned exactly, which
can prevent deduping across consumer trees. Update the dependency entry in
package.json for ai to use a caret range instead of an exact version, unless
this package explicitly requires a fixed pin for compatibility during the
migration.
In `@packages/documents/src/BlockDocumentEditor/BlockDocumentToolbar.tsx`:
- Around line 94-114: The new dashboard toolbar action in BlockDocumentToolbar
should be covered by tests similar to the existing toolbar button cases. Add or
update a test that renders BlockDocumentToolbar, clicks the dashboard button,
and verifies insertAtomBlock is called with blockDocumentStatefulBlock plus the
dashboard-specific attrs such as blockType, ownership, title, caption, height,
and a generated blockInstanceId. Use the existing toolbar test setup and any
shared helpers/mocks around insertAtomBlock and generateBlockId to keep the test
aligned with the current suite.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6c3bb110-34d2-4fba-a5e1-2d806af58acf
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (21)
apps/sqlrooms-cli-ui/src/__tests__/createCliBlockDocumentAiAdapter.test.tsapps/sqlrooms-cli-ui/src/__tests__/createCliBlockDocumentCommands.test.tsapps/sqlrooms-cli-ui/src/ai/__tests__/createCliBlockDocumentAiTools.test.tsapps/sqlrooms-cli-ui/src/ai/constants.tsapps/sqlrooms-cli-ui/src/ai/createCliBlockDocumentAgentTool.tsapps/sqlrooms-cli-ui/src/ai/createCliBlockDocumentAiTools.tsapps/sqlrooms-cli-ui/src/components/useLocalFileLoader.tsapps/sqlrooms-cli-ui/src/createBlockDocumentAgent.tsapps/sqlrooms-cli-ui/src/createCliBlockDocumentAiAdapter.tsapps/sqlrooms-cli-ui/src/createCliBlockDocumentCommands.tsapps/sqlrooms-cli-ui/src/store.tspackages/ai-core/package.jsonpackages/ai-rag/package.jsonpackages/ai/package.jsonpackages/artifacts/package.jsonpackages/deck/package.jsonpackages/documents/package.jsonpackages/documents/src/BlockDocumentEditor/BlockDocumentToolbar.tsxpackages/mosaic/package.jsonpackages/vega/package.jsonpackages/webcontainer/package.json
This reverts commit 154cb73.
ilyabo
reviewed
Jul 7, 2026
ilyabo
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Chores