Repository navigation
feat: share schema type category helpers - #792
Conversation
|
Warning Review limit reached
Next review available in: 14 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 871b1ebf8d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export function isColumnQuantitative(column: ColumnTypeLike): boolean { | ||
| const category = getColumnTypeCategory(column); | ||
| return category === 'number' || category === 'datetime'; |
There was a problem hiding this comment.
For DuckDB BIT/BIT(...) columns, getColumnTypeCategory returns string because the category table still matches ^bit under strings, while isColumnNumeric special-cases the same type as numeric. Since isColumnQuantitative only checks the category, isQuantitativeType('BIT') in mosaic now returns false even though BIT is still listed in QUANTITATIVE_COLUMN_TYPES, so existing BIT-backed histogram fields or line-chart X fields are rejected by validation after this change.
Useful? React with 👍 / 👎.
…n-map-selector # Conflicts: # packages/deck/src/MapSettings.tsx
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b29295a72e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /^timestamp$/, | ||
| /^timestamp_s$/, | ||
| /^timestamp_ms$/, | ||
| /^timestamp_ns$/, | ||
| /^timestamptz$/, |
There was a problem hiding this comment.
When DuckDB/MotherDuck field metadata uses the canonical TIMESTAMP WITH TIME ZONE spelling for a TIMESTAMPTZ column, none of these exact timestamp patterns match. This regresses the previous DataTableExplorer mapping (/^timestamp/ matched that value): fieldInfoToDataTableExplorerField now falls through to Utf8, so timezone timestamp columns are summarized and filtered as strings instead of date histograms.
Useful? React with 👍 / 👎.
Summary
@sqlrooms/duckdb-coresemantic column category helpers and selector-facing predicates@sqlrooms/duckdband document the public APIStacked on
codex/generated-column-map-selector)Validation
pnpm --filter @sqlrooms/duckdb-core typecheckpnpm --filter @sqlrooms/duckdb-core testpnpm --filter @sqlrooms/duckdb typecheckpnpm --filter @sqlrooms/deck typecheckpnpm --filter @sqlrooms/deck test -- useDeckMapDatasetSchema.test.tspnpm --filter @sqlrooms/mosaic typecheckpnpm --filter @sqlrooms/mosaic test -- data-table-explorer.utils.test.tsknip,turbo typecheck, circular dependency check,turbo test