fix(deck): compile all color scale properties on a layer - #781

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

packages/deck/src/json/colorScaleFunction.ts (1)

34-59: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Missing tsdoc on new exported API surface.

ColorScalePropName, getColorScale, and getAllColorScales are new/modified exported symbols with no tsdoc.

As per coding guidelines, "Add tsdoc to exported types and functions in @sqlrooms/* packages."

📝 Example tsdoc additions

+/** Names of layer accessor props that can carry a color scale. */
 export type ColorScalePropName =
   | 'getFillColor'
   | 'getLineColor'
   | 'getColor'
   | 'getSourceColor'
   | 'getTargetColor';

+/**
+ * Returns the first color scale entry found on the layer props, if any.
+ * `@deprecated` Prefer {`@link` getAllColorScales} when a layer may define multiple color scale accessors.
+ */
 export function getColorScale(props: Record<string, unknown>):
   ...

+/** Returns every color scale entry found across all known accessor props on the layer. */
 export function getAllColorScales(props: Record<string, unknown>): Array<{

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/deck/src/json/colorScaleFunction.ts` around lines 34 - 59, Add tsdoc
for the new exported API in colorScaleFunction.ts: document ColorScalePropName,
getColorScale, and getAllColorScales. Use concise tsdoc comments on each
exported type/function describing what color scale properties they cover and
what each function returns, keeping the docs aligned with the existing
getAllColorScales/getColorScale behavior.

Source: Coding guidelines

packages/deck/src/json/extractColorScaleLegends.ts (1)

53-119: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

No test coverage for multi-scale legend extraction.

extractColorScaleLegends now loops and builds a legend per color scale, but only createDeckJsonConfiguration.test.ts gained multi-accessor tests; no test exercises this file's new looping/per-legend error-handling behavior (e.g. a layer with getFillColor + getLineColor, or getSourceColor + getTargetColor, producing two distinct legends).

As per coding guidelines, "Add or update tests when changing behavior or public API, when practical."

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/deck/src/json/extractColorScaleLegends.ts` around lines 53 - 119,
Add tests for extractColorScaleLegends to cover the new per-color-scale loop and
fallback behavior. In the tests for extractColorScaleLegends, use a layer with
multiple resolved color scales (for example getFillColor plus getLineColor, or
getSourceColor plus getTargetColor) and assert that it returns a separate legend
for each scale. Also verify the error-handling path by making one color scale
fail in buildColorScaleLegend while another succeeds, and confirm the successful
legend is still returned.

Source: Coding guidelines