fix: Mosaic table references for memory-backed datasets - #774

packages/mosaic/src/ai/block-document/createBlockDocumentChartTools.ts (1)

41-57: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

Normalize the fallback table identity too.

If findTable() misses, the raw tableName is stored unchanged, so whitespace-only or padded names bypass the canonical identity path.

Proposed fix

     addChart: ({config, tableName, title}) => {
-      if (!tableName) {
+      const requestedTableIdentity = getMosaicTableIdentity(tableName ?? '');
+      if (!requestedTableIdentity) {
         throw new Error(
           'tableName is required for block document chart blocks but was empty or undefined',
         );
       }
 
-      const resolvedTable = databaseAdapter.findTable(tableName);
+      const resolvedTable = databaseAdapter.findTable(requestedTableIdentity);
       const tableIdentity = resolvedTable?.table
         ? getMosaicTableIdentity(resolvedTable.table)
-        : tableName;
+        : requestedTableIdentity;

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/mosaic/src/ai/block-document/createBlockDocumentChartTools.ts`
around lines 41 - 57, The fallback table identity in addChart is not normalized
when databaseAdapter.findTable() returns nothing, so padded or whitespace-only
names can be stored as-is. Update createBlockDocumentChartTools’s addChart logic
so the tableName fallback goes through the same normalization/canonicalization
path as resolvedTable.table, using getMosaicTableIdentity or equivalent
normalization before passing tableName into blockDocumentAdapter.addBlock.

packages/mosaic/src/ai/block-document/createBlockDocumentDataTableExplorerTool.ts (1)

49-76: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

Normalize the fallback table identity before storing it.

When resolution fails, this persists the original tableName, skipping the trimming/canonicalization that getMosaicTableIdentity provides.

Proposed fix

     databaseAdapter,
     addDataTable: async ({title, tableName, intent}) => {
-      if (!tableName) {
+      const requestedTableIdentity = getMosaicTableIdentity(tableName ?? '');
+      if (!requestedTableIdentity) {
         throw new Error(
           'Table name is required to add a data table explorer block',
         );
       }
 
       blockDocumentAdapter.ensureBlockDocument(blockDocumentId);
-      const resolvedTable = databaseAdapter.findTable(tableName);
+      const resolvedTable = databaseAdapter.findTable(requestedTableIdentity);
       const tableIdentity = resolvedTable?.table
         ? getMosaicTableIdentity(resolvedTable.table)
-        : tableName;
+        : requestedTableIdentity;

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@packages/mosaic/src/ai/block-document/createBlockDocumentDataTableExplorerTool.ts`
around lines 49 - 76, The fallback table identity in addDataTable should be
normalized before it is stored, because the current resolvedTable?.table ?
getMosaicTableIdentity(...) : tableName path skips canonicalization when lookup
fails. Update createBlockDocumentDataTableExplorerTool so the tableName fallback
also goes through getMosaicTableIdentity (or equivalent normalization logic)
before passing it to addDataTableExplorerBlock, createDataTableExplorerBlock,
and blockDocumentAdapter.addBlock.