You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat: Add python block artifacts to the CLI UI - #762
Adds 'python' as a new experimental artifact type to the CLI UI. The type literal is appended to CLI_ARTIFACT_TYPES, a pythonBlockDefinition is constructed and registered in createCliArtifactTypes() behind the withStability experimental gate, and createDashboardCommands.ts gains create and select command branches that call state.python.ensureBlock.
Changes
Python Artifact Type Registration
Layer / File(s)
Summary
Type contract, block definition, and artifact type registration apps/sqlrooms-cli-ui/src/artifactTypeIds.ts, apps/sqlrooms-cli-ui/src/artifactTypes.tsx
'python' is added to CLI_ARTIFACT_TYPES (expanding the CliArtifactType union), createPythonBlockDefinition is imported, ARTIFACT_STABILITY gains python: 'experimental', pythonBlockDefinition is constructed, and the type is registered in createCliArtifactTypes() via withStability(..., experimentalEnabled).
Dashboard create and select command handlers apps/sqlrooms-cli-ui/src/createDashboardCommands.ts
createArtifactCommand's execute adds an artifactType === 'python' branch calling state.python.ensureBlock; ARTIFACT_CREATE_COMMANDS gains a 'python' factory entry; artifact.select's execute adds an artifact.type === 'python' branch calling state.python.ensureBlock.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
sqlrooms/sqlrooms#616: Modifies the same createArtifactCommand execute logic in createDashboardCommands.ts, changing the title passed during generic artifact creation.
sqlrooms/sqlrooms#747: Overlaps at the artifact create/select command layer in createDashboardCommands.ts, adding artifactTargetChange to create/select responses for chat handoff.
Poem
🐇 A new artifact hops into the nest,
Python joins the CLI quest!
Experimental flag held high, ensureBlock waves a warm goodbye.
The warren grows, one type more — 🐍
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name
Status
Explanation
Resolution
Docstring Coverage
⚠️ Warning
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.
Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name
Status
Explanation
Description Check
✅ Passed
Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Title check
✅ Passed
The title accurately and concisely describes the primary change: adding Python block artifact support to the CLI UI across all three modified files.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches📝 Generate docstrings
Create stacked PR
Commit on current branch
🧪 Generate unit tests (beta)
Create PR with unit tests
Commit unit tests in branch add-python-block-artifact
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pythonto the CLI artifact type registry and stability mapTesting
Summary by CodeRabbit