Repository navigation
fix: Polish CLI sidebar interactions and layout overflow - #733
Merged
Merged
Conversation
…crollbars # Conflicts: # apps/sqlrooms-cli-ui/src/components/AssistantChatContainer.tsx
Contributor
📝 WalkthroughWalkthroughThe PR refactors both collapsed sidebar sections ( ChangesSidebar Popover/Command UI Refactor
ScrollArea & Overflow Layout Fixes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ilyabo
changed the title
ilyabo
marked this pull request as ready for review
June 19, 2026 09:42
# Conflicts: # packages/mosaic/src/charts/MosaicChart.tsx
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/sqlrooms-cli-ui/src/workspace/sidebar/CliDataSidebarSection.tsx (1)
78-173: 🏗️ Heavy liftAdd regression tests for the new collapsed Data sidebar flows.
This introduces new behavior (search/select table, modal preview opening, and add-data command in collapsed mode) but no test updates are included in the provided changes. Please add/update tests to lock this interaction path.
As per coding guidelines, "Add or update tests when changing behavior or public API, when practical."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/sqlrooms-cli-ui/src/workspace/sidebar/CliDataSidebarSection.tsx` around lines 78 - 173, The new collapsed mode functionality for CliDataSidebarSection component is missing test coverage. Add tests that verify the collapsed state branch (when state is not 'expanded') including: the popover opens and closes correctly using the popoverOpen state and setPopoverOpen handler, table search and selection works via the CommandItem elements that invoke handlePreviewTable, the DataTableModal opens with the correct preview table data when a table is selected, and the add-data CommandItem properly calls addData and closes the popover (by setting popoverOpen to false) when selected.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@apps/sqlrooms-cli-ui/src/workspace/sidebar/CliDataSidebarSection.tsx`:
- Around line 78-173: The new collapsed mode functionality for
CliDataSidebarSection component is missing test coverage. Add tests that verify
the collapsed state branch (when state is not 'expanded') including: the popover
opens and closes correctly using the popoverOpen state and setPopoverOpen
handler, table search and selection works via the CommandItem elements that
invoke handlePreviewTable, the DataTableModal opens with the correct preview
table data when a table is selected, and the add-data CommandItem properly calls
addData and closes the popover (by setting popoverOpen to false) when selected.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2f6379e4-a7b1-4967-a34e-c5e58e5f21d4
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (15)
apps/sqlrooms-cli-ui/package.jsonapps/sqlrooms-cli-ui/src/components/AssistantChatContainer.tsxapps/sqlrooms-cli-ui/src/components/AssistantPanel.tsxapps/sqlrooms-cli-ui/src/workspace/sidebar/CliArtifactsSidebarSection.tsxapps/sqlrooms-cli-ui/src/workspace/sidebar/CliDataSidebarSection.tsxapps/sqlrooms-cli-ui/src/workspace/sidebar/CliWorkspaceSidebar.tsxapps/sqlrooms-cli-ui/src/workspace/sidebar/useCliArtifactSidebarTabs.tspackages/layout/src/node-renderers/grid-node-renderer/GridLayout.tsxpackages/mosaic/__tests__/mosaicTableReference.test.tspackages/mosaic/src/charts/MosaicChart.tsxpackages/mosaic/src/charts/chart-settings/MosaicChartSpecViewerPanel.tsxpackages/mosaic/src/dashboard/panel/MosaicDashboardPanelLayout.tsxpackages/mosaic/src/mosaicTableReference.tspackages/sql-editor/src/components/SchemaExplorer.tsxpackages/sql-editor/src/components/TableStructurePanel.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataTableModalwhen selecting a tableTesting
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Improvements